bitshares / bitshares/bitshares-ui

[1][react-cat] Market picker select nonexistent trading pair

Open
#3,018 7 comments 0 reactions 0 assignees View on GitHub
[1b] User Story [3] Enhancement [5a] Tiny
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Describe the bug**
User have an ability to select nonexistent trading pair what causes crash of market picker

**To Reproduce**
Steps to reproduce the behavior:
1. Go to market
2. Open market picker and select TESTBTSHKD as a first asset
3. See that you can't open market picker anymore

**Expected behavior**
User should have an ability to select trading pairs that can't be trade

**Screenshots**
![marketPickerBug](https://user-images.githubusercontent.com/43940398/62709492-224fd600-b9fe-11e9-8328-24090ebe7454.gif)

**Desktop (please complete the following information):**
- OS: Ubuntu 16.04.5 LTS
- Browser Chrome
- Version 72.0.3626.96

Contributor guide

Open the contributing guide

Research direction

Start at the market picker flow in the React frontend and reproduce the issue by selecting TESTBTSHKD as the first asset. Trace the handling of a nonexistent trading pair and verify that the market picker remains usable while preserving the expected ability to select pairs that cannot be traded.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.