bitshares / bitshares/bitshares-ui

[3] Promisify SendModal

Open
#2,944 2 comments 0 reactions 1 assignee Claimed by @OpenLedgerApp View on GitHub
[1c] Task [2] Advanced Issue [3] Enhancement [5c] Medium
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

I always feel that the
`let account = ChainStore.getAccount(accountName);` is abusing the re-render and Promise premise. Very often you see afterwards ` if (account)` which then triggers the rendering, but this needs a possibly never happening re-render of the component.

I want the SendModal to use Promises in a proper way (e.g. through FetchChainObject or any of the other promisified functions). This issue is for refactoring accordingly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.