bitshares / bitshares/bitshares-ui

ES export errors

Open
#2,218 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

Happy to finally be able to export log files, I encountered the following weirdness on an account I have tried out DEXBOT on:

1. ES accumulates trades at executed at the same price. Even though they are days between which makes it look weird. And of course this will happen when using the staggered method. I am positive this will not pass the accounting.

2. When stopping the bot and importing it to cointracking, I had 0,30056 BTS less than I had in real life. Weird. So I took this difference and devided it with 0.00578 and found I had 52 to many of this fee in the output from the ES export. Or didn't the fees get paid? that's also a possibility.

https://www.dropbox.com/s/smp7ttt0q6lkvvg/Screenshot%202018-11-25%2016.51.36.png?dl=0

vs:

https://www.dropbox.com/s/muenpzjzhy488ib/Screenshot%202018-11-25%2016.51.16.png?dl=0

You can see the export here and compare to http://cryptofresh.com/u/external1

https://www.dropbox.com/s/px8kontpxzog2te/BTS-external1%20btshist-2018-11-25-1026.csv?dl=0

On a positive sidenote, the WLS balance is intact. While the fee paying balance is not.

To conclude:

While the export function is nice, it is not compatible with common accounting principles the way it lumps different transactions together. And there is something wrong with the way fees are handled.

I have second thoughts on using it extensively. Which is a shame, because that was my intention.

Contributor guide

Open the contributing guide

Research direction

No source files or tests are named. Start by reproducing the ES export and comparing its CSV with the supplied screenshots and the cryptofresh account history; done means the export preserves separate transactions and reports fee totals and balances accurately.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.