bitshares / bitshares/bitshares-ui

Price Alert window and tooltips

Open
#2,204 10 comments 0 reactions 0 assignees View on GitHub
[1c] Task [2] Verified [3] Enhancement [4b] Normal Priority
Dominant language
JavaScript
Stars
520
Forks
575
Avg merge
12h 7m
Merged PRs (30d)
5

Description

**Describe the bug**
1. Initially upon first time clicking the Price Alert, the pop up window appears void of data in the price
field.
![init_price_alert_capture](https://user-images.githubusercontent.com/18186497/48953269-e249d100-ef0a-11e8-9dd3-e3bc58e28178.JPG)

Closing and reopening the window shows a price in the price field.
![init_price_alert_2_capture](https://user-images.githubusercontent.com/18186497/48953284-eb3aa280-ef0a-11e8-9296-a3ce86adf4b5.JPG)

2. Opening the Price Alert window blocks the asset chart and the prices cannot be seen without closing
the window. The user either has to copy/paste their target price or remember/write it down prior to
setting the alert. Consider moving slightly to the left to reveal the chart pricing while the Price Alert
window is open
3. Price Alert window tooltips unresponsive

**To Reproduce**
Steps to reproduce the behavior:
1. Go to account, click on Exchange tab
2. Click on an asset pair (BTS:Open.BTC)
3. Click on the Price Alert icon
4. Note empty price field
5. Click cancel closing the Price Alert window
6. Reopen the Price Alert window by clicking the Price Alert icon
7. Note data now present in the price field
8. Note that the Price Alert window blocks the chart prices
9. With the Price Alert window open, hover over the first asset in the pair.
10. Note that a question mark tooltip appears.
11. Hover over the second asset in the pair
12. Note that there is no tooltip or the question mark

**Expected behavior**
1. Ability to see the chart price with the Price Alert window open
2. Automatically suggested price in the price field of the Price Alert window
3. Tooltip explaining what the Price Alert icon is for
4. Tooltips within the Price Alert window to function

**Desktop (please complete the following information):**
- OS: Windows 8.1
- Browser Opera

**Additional context**
Note:
1. With Devtools open, the Price Alert window is left aligned enough to see the prices within the chart
![init_price_alert_3_capture](https://user-images.githubusercontent.com/18186497/48954695-428f4180-ef10-11e8-8896-22d90f046a04.JPG)

2. Engaging with Devtools enabled the suggested price in the Price Alert field.
3. From within the Price Alert window, clicking on or engaging devtools enabled the asset pair tooltip
but only when the first asset is clicked or hovered over.

Contributor guide

Open the contributing guide

Research direction

Start from the Exchange tab's Price Alert icon and window, then reproduce the empty suggested-price field, chart obstruction, and tooltip behavior with the asset pair shown in the issue. Compare the first and reopened window states and test hovering both assets; done means the suggested price, chart visibility, and all described tooltips work consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.