bitshares / bitshares/bitshares-core

Update / Add API to query for open orders with pagination

Open
#463 10 comments 0 reactions 1 assignee Claimed by @abitmore View on GitHub
1b User Story 2a Discussion Needed 3c Enhancement 6 API 6 CLI api cli feature
Dominant language
C++
Stars
1.2k
Forks
660
Avg merge
8h 17m
Merged PRs (30d)
26

Description

IIRC we have 2 sets of API's related to query for open orders of one account in one market:
* `get_full_accounts`
* `get_limit_orders` + `get_settle_orders` + `get_call_orders`

However, both will return extra data and have some limitations, E.G. no pagination.

IMHO we need these API's:
- for `limit_order`
- [ ] get_limit_orders_by_market: one market, for all accounts, with pagination
- [x] `get_limit_orders_by_account`: all markets, for one account, with pagination
- [x] get_limit_orders_by_account_market `get_account_limit_orders`: one market, for one account, with pagination
- for `call_order`
- [ ] get_call_orders_by_asset: one asset, for all accounts, with pagination
- [x] `get_call_orders_by_account`: all assets, for one account, with pagination
- [ ] get_call_orders_by_account_asset: one asset, for one account, with pagination (note: `get_call_orders_by_account` can be used for this)
- for `settle_order`
- [ ] get_settle_orders_by_asset: one asset, for all accounts, with pagination
- [x] `get_settle_orders_by_account`: all assets, for one account, with pagination
- [ ] get_settle_orders_by_account_asset: one asset, for one account, with pagination

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.