bitshares / bitshares/bitshares-core

P2P code test coverage

Open
#2,006 0 comments 0 reactions 0 assignees View on GitHub
1b User Story 2a Discussion Needed 3c Enhancement 6 P2P testing
Dominant language
C++
Stars
1.2k
Forks
660
Avg merge
8h 17m
Merged PRs (30d)
26

Description

**User Story**
As a developer or user I want to see more of the P2P networking code covered by tests in order to increase my confidence in the software.

**Impacts**
- [ ] API (the application programming interface)
- [ ] Build (the build process or something prior to compiled code)
- [ ] CLI (the command line wallet)
- [ ] Deployment (the deployment process after building such as Docker, Travis, etc.)
- [ ] DEX (the Decentralized EXchange, market engine, etc.)
- [x] P2P (the peer-to-peer network for transaction/block propagation)
- [ ] Performance (system or user efficiency, etc.)
- [ ] Protocol (the blockchain logic, consensus, validation, etc.)
- [ ] Security (the security of system or user data, etc.)
- [ ] UX (the User Experience)
- [x] Other (please add below)
Code quality

**Additional Context (optional)**
See also https://github.com/bitcoin/bitcoin/issues/14210

Ideas:
[ ] unit tests
[ ] smoke test (during Travis build)
[ ] network stress test
[ ] protocol simulator

## CORE TEAM TASK LIST
- [ ] Evaluate / Prioritize Feature Request
- [ ] Refine User Stories / Requirements
- [ ] Define Test Cases
- [ ] Design / Develop Solution
- [ ] Perform QA/Testing
- [ ] Update Documentation

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by surveying the C++ P2P networking code and its existing tests; the issue does not identify files, entry points, or specific behaviors. Define test cases and coverage targets for the P2P code, then verify that the added unit, smoke, stress, or simulator tests run successfully and improve coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking, testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.