bitshares / bitshares/bitshares-core

add pagination and limit to get_key_references and get_account_references

Open
#1,753 5 comments 0 reactions 0 assignees View on GitHub
6 API
Dominant language
C++
Stars
1.2k
Forks
660
Avg merge
8h 17m
Merged PRs (30d)
26

Description

UI team requesting this at https://github.com/bitshares/bitshares-core/pull/1749#discussion_r282520956

By the way, please fix the duplicate result issue (#1209), see the example below. Perhaps change the return data type from `vector` to `vector` or `vector`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the get_key_references and get_account_references implementations and the UI discussion in pull request 1749. Then inspect issue 1209 and its duplicate-result example to understand the expected behavior. Done means both reference queries support pagination and limits, while duplicate results are eliminated and covered by the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.