bitshares / bitshares/bitshares-core

add get_asset_markets

Open
#1,101 1 comment 0 reactions 0 assignees View on GitHub
1b User Story 2a Discussion Needed 3b Feature 4b Normal Priority 5a Docs Needed 6 API api
Dominant language
C++
Stars
1.2k
Forks
660
Avg merge
8h 17m
Merged PRs (30d)
26

Description

As a `explorer/exchange` I want `get_asset_markets(asset_id)` so that i can get a list of active markets in the last 24 hours for an asset.

This call should be added to `asset_api` (disabled by default) as it will have some performance issues.

Explorers and exchanges will use this call to populate active markets as: http://open-explorer.io/#/assets/1.3.3262
This is currently done client side looping once every X hours all assets, resulting in no uptodate results.

To be done after https://github.com/bitshares/bitshares-core/pull/1099

**Impacts**
Describe which portion(s) of BitShares Core may be impacted by your request. Please tick at least one box.
- [x] API (the application programming interface)
- [ ] Build (the build process or something prior to compiled code)
- [ ] CLI (the command line wallet)
- [ ] Deployment (the deployment process after building such as Docker, Travis, etc.)
- [ ] DEX (the Decentralized EXchange, market engine, etc.)
- [ ] P2P (the peer-to-peer network for transaction/block propagation)
- [ ] Performance (system or user efficiency, etc.)
- [ ] Protocol (the blockchain logic, consensus, validation, etc.)
- [ ] Security (the security of system or user data, etc.)
- [ ] UX (the User Experience)
- [ ] Other (please add below)

**Additional Context (optional)**
Add any other context about your request here.

## CORE TEAM TASK LIST
- [ ] Evaluate / Prioritize Feature Request
- [ ] Refine User Stories / Requirements
- [ ] Define Test Cases
- [ ] Design / Develop Solution
- [ ] Perform QA/Testing
- [ ] Update Documentation

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing bitshares-core pull request 1099, then inspect the asset_api entry point mentioned in the issue. The change is complete when get_asset_markets(asset_id) can return an asset's active markets from the last 24 hours and remains disabled by default because of its performance cost.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api, blockchain
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.