bitshares / bitshares/bitshares-core

Backport EOS GELF udp fixes

Open
#1,005 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.2k
Forks
660
Avg merge
8h 17m
Merged PRs (30d)
26

Description

A "would_block" asio error when logging could needlessly throw, and should probably be ignored.

See https://github.com/EOSIO/eos/pull/2458
also https://github.com/EOSIO/eos/commit/9224efeaa8e47a124996c8e8f849ecd1eb85b224

Moved from #997 as it is a separate issue.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading the referenced EOSIO pull request #2458 and commit 9224efeaa8e47a124996c8e8f849ecd1eb85b224, then locate the BitShares GELF UDP logging path. Confirm the backport handles the asio "would_block" error without needlessly throwing, and verify the logging behavior with the relevant existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
networking, observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.