bitovi / bitovi/syn

Modifier keys aren't working for typed sequences.

Open
#70 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
441
Forks
254
PR merge metrics
No merged PRs in 30d

Description

So I ran into something where the modifier keys (Shift, Alt, etc.) weren't being toggled for a key sequence because the 'Syn.support.ready' value wasn't the value of 2 as is necessary to run the setup functions for those events.

This value is incremented by code in key.support.js and mouse.support.js (once in each, hence the value of 2), but these files are not included in the 'syn.js' and 'syn.min.js' files produced by the Grunt build.

I went ahead and set this value in other JS code that lives in the same space as Syn and all is well, but it's pretty hacky. Others might be having trouble with this as it's subtle and not-at-all easy to diagnose. I wasn't sure what the best way to fix this was, so I thought I'd just report it as an issue.

Contributor guide

Open the contributing guide

Research direction

Inspect the Grunt build configuration and compare the inputs for syn.js and syn.min.js with key.support.js and mouse.support.js. Run the existing build and reproduce a typed sequence with Shift or Alt; done means both support files are included in the generated bundles and modifier keys are toggled correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.