bitovi / bitovi/launchpad

Finding Edge Fails when Edge DevTools are enabled

Open
#113 1 comment 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
JavaScript
Stars
48
Forks
28
PR merge metrics
No merged PRs in 30d

Description

When windows `getEdgeDirectory` runs, this filter

https://github.com/bitovi/launchpad/blob/b1d254a9fe405691c7a13d0c4de8b39edff4f313/lib/local/platform/windows.js#L90-L91

results in inclusion of both these paths:
* `"C:\Windows\SystemApps\Microsoft.MicrosoftEdge_8wekyb3d8bbwe"`
* `"C:\Windows\SystemApps\Microsoft.MicrosoftEdgeDevToolsClient_8wekyb3d8bbwe"`

On my system the DevToolsClient folder comes first, so launchpad returns that path right after.

https://github.com/bitovi/launchpad/blob/b1d254a9fe405691c7a13d0c4de8b39edff4f313/lib/local/platform/windows.js#L96

The DevToolsClient folder doesn't contain a copy of `MicrosoftEdge.exe` so launchpad fails to detect edge on my system.

## Easy fix
* Just filter again to remove paths that contain `DevToolsClient`
* or change the filter line 91 to have a trailing underscore (but this is more of a hack)

Contributor guide

No contributing guide indexed for this repository

Research direction

Read lib/local/platform/windows.js around getEdgeDirectory and the filter at lines 90-96. Verify the Windows Edge discovery flow no longer selects MicrosoftEdgeDevToolsClient before checking for MicrosoftEdge.exe; the issue is done when the real Edge installation is detected on systems with Edge DevTools enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
operating-systems
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.