force to kill instance on windows
Open
bug
help wanted
- Dominant language
- JavaScript
- Stars
- 48
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Description
i would recommend to force the killing process and use the PID
https://github.com/bitovi/launchpad/blob/master/lib/local/instance.js#L90
should be: `command = 'taskkill /f /pid ' + this.id;`
on my windows machine the `taskkill` was not working an node will not exit because a chrome will still exists
Contributor guide
No contributing guide indexed for this repository
Research direction
Open lib/local/instance.js at line 90 and inspect how the instance process is terminated on Windows. Reproduce the case where Chrome remains and Node does not exit, then verify that PID-based termination makes the instance shut down cleanly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100