bitnami / bitnami/sealed-secrets

tls and extraTls

Open
#1,324 2 comments 2 reactions 0 assignees View on GitHub
backlog chart
Dominant language
Go
Stars
9.3k
Forks
776
Avg merge
1d 13h
Merged PRs (30d)
30

Description

When adding something like a common-name to a certificate
```
ingress:
enabled: true
className: nginx
annotations:
cert-manager.io/cluster-issuer: letsencrypt
cert-manager.io/common-name: "sealed-secrets.platform.example.com"
tls: true
hostname: sealed-secrets.kustomize-me.clusters.aws.platform.example.com
extraHosts:
- name: sealed-secrets.platform.example.com
```

The tls hosts in the template shouldn't be a single host from ingress.hostname but in fact a list of hosts (hostname AND common-name). Most helm templates for ingress include a range to allow for multiple host names to be provided to the dnsNames of the cert.

Using extraTls doesn't match this model because it creates a completely separate certificate.

Most helm ingress values provide list of hosts vs a single hostname so that's why it scales but in this template that isn't the case.

https://github.com/bitnami-labs/sealed-secrets/blob/main/helm/sealed-secrets/templates/ingress.yaml#L46

Most charts (except for bitnami) use this type of format to have multiple hostnames
https://github.com/dexidp/helm-charts/blob/master/charts/dex/templates/ingress.yaml#L33

However the values format should look something more like:

```
ingress:
enabled: true
className: nginx
annotations:
cert-manager.io/cluster-issuer: letsencrypt
cert-manager.io/common-name: "sealed-secrets.platform.example.com"
hosts:
- host: sealed-secrets.kustomize-me.clusters.aws.platform.example.com
paths:
- path: /
pathType: ImplementationSpecific
- host: sealed-secrets.platform.example.com
paths:
- path: /
pathType: ImplementationSpecific
tls:
- hosts:
- sealed-secrets.kustomize-me.clusters.aws.platform.example.com
- sealed-secrets.platform.example.com
secretName: sealed-secrets-tls
```

Contributor guide

Open the contributing guide

Research direction

Start with helm/sealed-secrets/templates/ingress.yaml at the linked section and compare the referenced Dex chart pattern. Review the ingress values structure shown in the issue, then verify rendered output for multiple hosts and one shared TLS secret. Done means the primary hostname and extra hostnames are represented together rather than creating a separate certificate through extraTls.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.