bitemyapp / bitemyapp/blackwater

Korma queries don't log passed parameters

Open
#4 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Clojure
Stars
57
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I have a patch in progress (zerokarmaleft/blackwater@48a3ff50358ca6ec7409991a658398b9f082451b), but I figured I'd bounce the idea off of you first to see if you had a preference for a different approach. Changing the arity of `log-sql` breaks the jdbc module obviously, but it doesn't look like the jdbc hooks are adding passed parameters to the log output either.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the `log-sql` entry point and the JDBC hooks mentioned in the issue, then compare the proposed approach in commit 48a3ff50358ca6ec7409991a658398b9f082451b. Done means passed query parameters appear in log output while the JDBC module continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.