bitcoindevkit / bitcoindevkit/rust-electrum-client

Routinely returns `AllAttemptsErrored([])` on failed requests

Open
#186 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
89
Forks
82
Avg merge
2d 3h
Merged PRs (30d)
1

Description

In these parts of the code we returning **before** adding the latest error to the `errors: Vec<_>`. This causes this code to return `AllAttemptsErrored([])` which is a bit frustrating.

https://github.com/bitcoindevkit/rust-electrum-client/blob/761796c94ae29a41651914796c926bbabf8784c8/src/client.rs#L56-L65
https://github.com/bitcoindevkit/rust-electrum-client/blob/761796c94ae29a41651914796c926bbabf8784c8/src/client.rs#L80-L89

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.