bitcoindevkit / bitcoindevkit/bdk_wallet

Feerate should be returned from Transaction construction

Open
#187 9 comments 2 reactions 0 assignees View on GitHub
good first issue new feature
Dominant language
Rust
Stars
59
Forks
105
Avg merge
10d 9h
Merged PRs (30d)
1

Description

When you get TransactionDetails from `tx_builder.finish()` it has the fee for the overall transaction but does not include the feerate of the resulting transaction. There is no simple way for the caller to replicate this information since the transaction does not have witness data at this point. This is annoying because after constructing the psbt the user should know the feerate before signing it.

This can either be done by returning another value from `builder.finish()` or by adding a (perhaps optional) field to `TransactionDetails`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.