bitcoindevkit / bitcoindevkit/bdk-reserves

Possible path for removing `bitcoinconsesnus` dependency??

Open
#7 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
20
Forks
11
PR merge metrics
No merged PRs in 30d

Description

The `bitcoinconsensus` crate is used to do the proof verification here https://github.com/weareseba/bdk-reserves/blob/61b5f517f4c227bdf62507d1fcc2fd79bb87db8d/src/reserves.rs#L273-L279

BDK exposes a very similar functionality in the wallet api itself with the `verify` feature flag and uses the same `bitcoinconsensus` underneath like this..

https://github.com/bitcoindevkit/bdk/blob/2283444f727b85663b19d100af86db4392ebc891/src/wallet/verify.rs#L58-L68

This api is publicly exposed via `verify` feature of BDK.. So may be one more opportunity to reduce external dependency on `bitcoinconsensus`??

But might need some restructuring of the proof verification logic in this crate..

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.