bitcoindevkit / bitcoindevkit/bdk-ffi
Implement `From<uniffi::UnexpectedUniFFICallbackError>` for `FullScanScriptInspector` and `SyncScriptInspector`
- Dominant language
- Rust
- Stars
- 127
- Forks
- 81
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 5
Description
We have two `#[uniffi::export(with_foreign)]` in this library that still don't implement the recommended `impl From for ...`. Opening this to keep track. These would be non-breaking changes.
See [the not very verbose Mozilla docs](https://mozilla.github.io/uniffi-rs/latest/foreign_traits.html#unexpected-error-handling) on this.
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the two #[uniffi::export(with_foreign)] implementations for FullScanScriptInspector and SyncScriptInspector, then read Mozilla’s UniFFI unexpected-error-handling documentation. Add the recommended conversions for both types and verify that the library builds and its existing checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100