bitcoin-dev-project / bitcoin-dev-project/sim-ln

Remove trailing full stop from log lines

Open
#134 6 comments 1 reaction 0 assignees View on GitHub
feature Low Priority nit
Dominant language
Rust
Stars
80
Forks
40
Avg merge
18h 49m
Merged PRs (30d)
2

Description

**Describe desired feature**

This is pretty opinionated, but I think log lines should not end in full stop

**Use case for feature**

Being able to copy info from the terminal without carrying over the full stop. Right now, if you try to copy data from the terminal by double-clicking on it to select it (such as node ids, hashes, ...) the full stop will be carried over. Here are some examples:

```
> 2023-10-10T15:50:09.139Z INFO [sim_cli] Connected to alice - Node ID: 02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.

02c7e2f01ea946252b29a2e24629d67df3740f3db448ec42a1bccb52e2b7482b2a.

> 2023-10-10T15:50:15.195Z DEBUG [sim_lib] Tracking payment outcome for: 6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.

6fd79189307a9db7e685c0ffcd909d46a5a25f2cb736753080e7092d856ab47a.
```

**Would you like to contribute code for this feature?**

Sure, if we reach consensus about it

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.