bisq-network / bisq-network/style

Submit pull request reviews using GitHub's "Review changes" button

Open
#7 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
2
Forks
2
PR merge metrics
No merged PRs in 30d

Description

When reviewing a pull request, do not just add a normal comment, but actually click the "Review changes" button and add your summary using the ACK / NACK language at #6.

This makes it easier for everyone to see that a review has already been submitted for a given pull request without having to scroll through comments, makes it possible to search for pull requests without reviews, pull requests reviewed by a certain user, etc. It also makes the review comment itself that much more prominent, because it shows up with a big green checkmark, red X.

![image](https://user-images.githubusercontent.com/301810/37638495-78c8436c-2c0d-11e8-8b79-b993a6c63715.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with GitHub's pull request review flow and the ACK/NACK guidance referenced in issue #6. Done means reviewers use the “Review changes” button instead of a normal comment and submit their summary through that review flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
github
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.