bisq-network / bisq-network/events

(Cancelled, Reschedule) Dev-Call "Pull Requests"

Open
#35 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Recently, we had a quite substantial PR queue build-up. Hence, we decided to talk about the whys and hows and how we can improve the workflow. The first part is seen as an informative Presentation on a suggested workflow, for the second part (the optimization part) we hope for a few suggestions from the audience.

# Agenda

- howto
- setup git (your id, pgp)
- fork bisq
- feature branch
- commit little, commit often
- check yo' stylin (try to match the surroundings)
- commit only changes related to the PR in question (no import reorgs)
- create PR
- await response from reviewers
- react, if change requests are not reacted to within 30 days, PR will be closed (no compensation)
- rebase and force-push you feature branch if necessary
- ask for compensation

- why does it take so long until PRs get merged
- formatting issues
- unnecessary code reorgs
- conflicts
- ...
- hence, PRs queue up
- maintainers are overburdened
- nothing moves

- optimize workflow
- use travis to check for formatting?
- use travis to check for bugs? (FindBugs, etc.)
- introduced the 30 days deadline
- we will be more rigorous with closing PRs if we feel that too much basic stuff is off

# Schedule

When: cancelled, reschedule ~Friday, 2019-11-22 13:00 CET~
Duration: 1,5h
How: https://zoom.us/j/753072189, web link https://zoom.us/wc/join/753072189?pwd=

Contributor guide

No contributing guide indexed for this repository

Research direction

This is a cancelled, rescheduled event announcement rather than an implementation task. No files, tests, or entry points are mentioned; the agenda and schedule are the only available scope, so completion would mean updating the event record if a new date is decided.

Written by the indexing model from the issue text.

Assessment

Tech stack
git
Domain
developer-experience, documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.