Possible bug in kNN with mahalanobis metric
- Dominant language
- Python
- Stars
- 5.7k
- Forks
- 1.1k
- Avg merge
- 12d 2h
- Merged PRs (30d)
- 1
Description
@VesnaT, I have put the code that manipulated the learner's params into `_initialize_wrapped` to avoid change the learner's parameters when fitting -- the same learner might be shared by multiple threads. Is your code (from 2016, I'm sure you still remember it :) that manipulates `metric_params` safe for multithreading?
_Originally posted by @janezd in https://github.com/biolab/orange3/issues/7309#issuecomment-5070155819_
Contributor guide
Research direction
Start by tracing the kNN implementation's handling of the mahalanobis metric and metric_params, then compare that behavior with the parameter manipulation moved into _initialize_wrapped. Determine whether shared learners can be mutated during fitting and verify the expected behavior for concurrent use; the issue names no files or tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100