biocore / biocore/microsetta-admin

Sample summary search returns error if only one barcode fails

Open
#98 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
0
Forks
10
PR merge metrics
No merged PRs in 30d

Description

During the sample summary search, the CSV option gives an option for users to upload several barcodes. However, if one of the barcodes fails to be found, the entire search aborts with the error message "Not Found" showed. @cassidysymons

**Observation**: When looping through the barcodes in `admin.sample_summary.per_sample()`, [this line](https://github.com/biocore/microsetta-private-api/blob/07a57578d63dc449b4b1e85cb80592a0a24767ea/microsetta_private_api/admin/sample_summary.py#L36) creates the early stopping condition that ends the entire function.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in microsetta_private_api/admin/sample_summary.py at admin.sample_summary.per_sample(), especially the linked line where barcode lookup creates the early stopping condition. Reproduce a CSV search with several barcodes including one that is not found, then verify that the search completes and handles the missing barcode without showing the whole-search "Not Found" error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.