biocore / biocore/empress

Autocomplete menu height can't extend below control panel height

Open
#446 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
56
Forks
32
PR merge metrics
No merged PRs in 30d

Description

This (along with #445) was something I noticed while testing #433 that ... turns out that it's already a problem in the main version of Empress. So it isn't strictly related to #433, I guess.

Basically, when the control panel `

` is short enough (this is easiest to notice when not a lot of data is passed to Empress, e.g. sample metadata is omitted, causing the `Sample Metadata Coloring` tab to be hidden), it's possible for the autocomplete menu to extend below it. However, the autocomplete menu isn't shown, and a weird sorta extra scroll bar comes up on the right side of the control panel:

![tooshort_maimn](https://user-images.githubusercontent.com/4177727/99353062-a7a87400-2858-11eb-89a7-f6908a0d8fe0.gif)

I think the expected behavior here should be modifying things so that the autocomplete menu can clearly extend below the control panel, arbitrarily low on the screen (since it has its own scroll bar already, even if it would go beyond the bottom of the screen that should still be ok).

I think this would be solvable through some CSS magic (maybe by restructuring things so that the autocomplete UI elements are not contained within the control panel, and are positioned absolutely? Not too familiar with the code here.) This is also pretty low priority, I guess, but would be good to address.

Contributor guide

Open the contributing guide

Research direction

No source file or test is named. Start by locating the control panel div and autocomplete UI, then reproduce the short-panel case described in the issue; done means the autocomplete menu remains visible below the panel, with its own scrollbar and without the extra control-panel scrollbar.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.