biocore / biocore/empress

Firefox breaks on the Legend tests

Open
#435 0 comments 0 reactions 0 assignees View on GitHub
bug testing
Dominant language
JavaScript
Stars
56
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Discovered by @kwcantrell in #400. Impacts the `addCategoricalKey` test. Kalen's comment copied below:

```js
// Note: firefox breaks on this test. chroma.js does not
// recognize "rgb(255, 0, 0" on firefox. This is not an
// issue for empress as we would not pass "rgb(r, g, b)" to
// chroma.js
```

Contributor guide

Open the contributing guide

Research direction

Start with the addCategoricalKey test mentioned in the issue and reproduce its behavior in Firefox, comparing it with the other browser results. Done means the Legend test passes in Firefox without breaking the existing test behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.