biocore / biocore/empress

Optimize side-panel-handler.

Open
#259 0 comments 0 reactions 0 assignees View on GitHub
performance refactoring
Dominant language
JavaScript
Stars
56
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Currently, side-panel-handler makes lot of needless calls to empress's resetTree/coloring functions. For example, every time the user changes line width, side-panel-handler will reset the tree, then recolor it (and potentially re-collapse), and then finally adjust the line thickness. However, adjusting line thickness can be done without resetting the tree. I don't think this is a huge issue right now. However, this may slow things down with larger trees.

It would also be nice to remove the update button.

Contributor guide

Open the contributing guide

Research direction

Start with side-panel-handler and trace its calls to empress's resetTree and coloring functions, especially when line width changes. Check how the update button is wired and identify whether both optimization and button removal belong in this issue. Done means line-width changes avoid unnecessary tree resets while preserving behavior, and the update button is removed if its behavior is in scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.