biocore / biocore/LabControl

Refactor updateUnknownsAndDuplicates to only check certain wells, making it more efficient

Open
#591 0 comments 0 reactions 0 assignees View on GitHub
code refactor front-end
Dominant language
Python
Stars
2
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Recapping this issue: I wrote the following comment in `patchWell()`—
https://github.com/biocore/LabControl/blob/10ef1ef11f677957f23dc9765235e5642a81e1e1/labcontrol/gui/static/js/plateViewer.js#L458-L472

@AmandaBirmingham responded to it [here](https://github.com/biocore/LabControl/pull/585#discussion_r322494558)—

>Probably. `updateUnknownsAndDuplicates` is completely agnostic to whatever change triggered it--but that means it has to be brute-force and re-check everything. I think it is the source of a lot of the performance issues in the platemapper, and probably needs to be rethought from the ground up. Could you add an issue to the repo for this, and then remove this comment?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.