biocore / biocore/LabControl

Sanitizing input text for "get" queries?

Open
#575 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
2
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Doesn't look like this has been logged as an issue before, so I'm documenting it here.

In the style of [xkcd](https://xkcd.com/327/), I tried plating a specimen with the ID `');console.log('hi');`. Fortunately, this doesn't result in `hi` being printed to the console; unfortunately, it does cause a 500 internal server error:

```
GET https://127.0.0.1:8181/study/1/samples?term=%27);console.log(%27hi%27); 500 (Internal Server Error)
```

Looks like it's the `'` character (which gets converted to `%27`) that's problematic.

I don't imagine this is a common use case, but it might be worth addressing?

Edit: also, if this behavior is expected (i.e. the server throws an error if it detects a wacky specimen ID like `');console.log('hi');`) then sorry, and feel free to close this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.