biocore / biocore/LabControl

Plate list page allows users to send unquantified compressed gdna plates to normalization page, which leads to error

Open
#485 0 comments 0 reactions 0 assignees View on GitHub
bug priority:low
Dominant language
Python
Stars
2
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Reproduction GIF below. On plate_list.html, user can pick *any* compressed gDNA plates and send them to the normalization.html page--but normalization can only be performed on compressed gDNA plates that have been quantified (via the parse_quantification.html page) . The normalization page prevents users from adding unquantified plates on it directly but does not catch the case where an unquantified plate is sent in via the querystring from plate_list.html. This means the user can go ahead and submit their normalization request to the back end and get a nasty python error.

![unquantified](https://user-images.githubusercontent.com/10677935/56697508-a1b1d780-66a3-11e9-84fd-0ce84ed7f727.gif)

I class this as a relatively low priority because I don't think the lab actually uses the "checkboxes from plate list" route very often. It is actually a big pain to manage and I would like to suggest we at least consider the possibility of axing it ...

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.