biocore / biocore/LabControl

Are transactions rolled back during failure?

Open
#472 13 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
2
Forks
15
PR merge metrics
No merged PRs in 30d

Description

While observing #470 and #471, it became apparent that transactions may not be honored as expected. In the attached .gif, two plates are added for prepare shotgun libraries. The first plate is added with the correct primer plates and the name "FOO", while the second one has the primer plates juggled and uses the name "BAR". An exception occurs, as described in #471 because the primer plates for "BAR" are incorrect. The .gif then shows an attempt to redo prepare shotgun libraries but this time only with the first plate, using the name "FOO", with the correct primers. We observe the duplicate name violation in #470. Despite the failure, the name "FOO" and possibly other state has been committed to the database.

![shotgun_library_index_transactions](https://user-images.githubusercontent.com/474290/56539742-9df34900-651b-11e9-8d45-c9b82ed69dce.gif)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.