biocore / biocore/BIRDMAn

Consider sklearn way of fitting

Open
#10 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
25
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Brought up by @gwarmstrong

In sklearn the `fit` function is where the data is input rather than the model constructor. Would be more intuitive to users familiar with sklearn but could require some rethinking of keeping feature names, sample names, etc.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the current model constructor and fit interface, then compare them with the scikit-learn fitting convention described in the issue. Trace how feature names and sample names are currently retained. Done requires an agreed design for moving data input into fit without losing that metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
bioinformatics, machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.