binance / binance/binance-futures-connector-java

WebSocket onFailure Why not return the connection information at that time

Open
#15 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
191
Forks
96
PR merge metrics
No merged PRs in 30d

Description

![Uploading image.png…]()
WebSocketConnection.onFailure,
```
@Override
public void onFailure(WebSocket ws, Throwable t, Response response) {
logger.error("[Connection {}] Failure", connectionId, t);
// Wouldn't it be better to just return null and return the connectionId
onFailureCallback.onReceive(null);
}
```
If one of the multiple subscriptions is disconnected, how do you retry without knowing the current subscription information Or throw the exception out

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading WebSocketConnection.onFailure and the onFailureCallback usage shown in the issue, then trace how multiple subscriptions are represented and retried. Determine whether the callback should expose connection information or propagate the exception, and document the expected behavior before making a change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.