bilelmoussaoui / bilelmoussaoui/Hardcode-Tray

Add support convert icon to ICO format

Open
#527 2 comments 0 reactions 1 assignee View on GitHub

@bilelmoussaoui is already working on this.

Since May 25, 2018.

enhancement
Dominant language
Python
Stars
889
Forks
59
PR merge metrics
No merged PRs in 30d

Description

This needed for Riot:
image

  • Exec path:
# on DEB
/opt/Riot/riot-web
# on ARCH
/usr/bin/riot-desktop
  • Initially program load PNG:
# on DEB
/opt/Riot/resources/app/img/riot.png
# on ARCH
/usr/lib/riot/electron_app/img/riot.png
  • After program load ICO:
# on DEB
/opt/Riot/resources/webapp/vector-icons/favicon.ico
# on ARCH
/usr/share/webapps/riot/vector-icons/favicon.ico

Example config (ICO format not converting):

{
    "name": "Riot Web",
    "app_path": [
        "/opt/Riot/riot-web",
        "/usr/bin/riot-desktop"
    ],
    "icons_path": [
        "/opt/Riot/resources/app/img/",
        "/opt/Riot/resources/webapp/vector-icons/",
        "/usr/lib/riot/electron_app/img/",
        "/usr/share/webapps/riot/vector-icons/"
    ],
    "icons": {
        "tray": {
            "original": "riot.png",
            "theme": "riot-tray"
        },
        "tray-ico": {
            "original": "favicon.ico",
            "theme": "riot-tray"
        }
    }
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.