biig-io / biig-io/DomainComponent

Dangerous usage of cacheableSupport in DomainDenormalizer

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
16
Forks
9
PR merge metrics
No merged PRs in 30d

Description

This line looks suspicious: https://github.com/biig-io/DomainComponent/blob/21a5bd0dda8585ebf7e3cfc5470074ae004cfad8/src/Integration/Symfony/Serializer/DomainDenormalizer.php#L82

It should probably be the following:

```php
return $this->decorated instanceof CacheableSupportsMethodInterface && $this->decorated->hasCacheableSupportsMethod();
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.