bigskysoftware / bigskysoftware/htmx
4.0 upgrade-check finds false positives for `[inheritance] ... needs :inherited suffix` for nested hx-* elements
- Dominant language
- JavaScript
- Stars
- 49.4k
- Forks
- 1.7k
- Avg merge
- 3d 22h
- Merged PRs (30d)
- 30
Description
Given a file with these contents:
```html
```
I get `[inheritance] hx-target needs :inherited suffix (descendant on line 2 has hx-get)`, but that I think is wrong, this message should not be shown if a potentially inherited hx-* attribute is explicitly overridden.
Full output:
```
npx htmx.org@4.0.0 upgrade-check -- inheritance.html
File extensions: .html, .php, .js, .ts, .jinja, .jinja2, .j2, .erb, .hbs
Use --ext to add more (e.g. --ext .vue --ext .svelte)
Scanning 1 file(s)...
inheritance.html:1: [inheritance] hx-target needs :inherited suffix (descendant on line 2 has hx-get)
Found 1 issue(s) in 1 of 1 file(s).
```
Contributor guide
Research direction
Reproduce the report with the shown inheritance.html contents and run `npx htmx.org@4.0.0 upgrade-check -- inheritance.html`. Trace the inheritance check that reports the line-1 hx-target warning; done means an explicitly overridden nested hx-target no longer produces this false positive, while relevant warnings remain detected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, javascript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 70/100