bigskysoftware / bigskysoftware/htmx

Default config object code comment mis-match

Open
#3,428 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
49.4k
Forks
1.7k
Avg merge
3d 22h
Merged PRs (30d)
30

Description

https://github.com/bigskysoftware/htmx/blob/81a6e25fb9cddc2846f27f494ab816fa32fc64c0/src/htmx.js#L239

Noticed that the default value for `selfRequestsOnly` is defined as `true`, yet the `@default` comment directly above it says that the default value is supposed to be false. I looked back at Git Blame to see if this was a recent change, or simply a mistaken comment that is out of date.

It should probably just say `@default true` in the comment, but didn't see this issue logged anywhere and didn't want to presume.

I'll open a PR and link it to this issue next.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.