bigskysoftware / bigskysoftware/contact-app

Pressing save and ignoring the error when editing contact allows duplicate email to be shown

Open
#18 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
130
Forks
59
PR merge metrics
No merged PRs in 30d

Description

Hey guys!

Working through the book and loving it!

I noticed that in the edit functionality if you ignore the errors for a duplicate or empty field it shows the incorrect information when you then press back. It is visible with the duplicate in the list. I thought it was just my code so I cloned the repo but it seems to have the same bug.

![Screenshot from 2024-03-02 19-13-59](https://github.com/bigskysoftware/contact-app/assets/106953272/a8978e20-af96-44b3-9891-95bfdbe87fe6)

![Screenshot from 2024-03-02 19-14-17](https://github.com/bigskysoftware/contact-app/assets/106953272/196677f3-a5a3-47e0-b654-b1359e4a9e60)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the edit-contact flow described in the issue: submit a duplicate or empty email, ignore the error, press Back, and inspect the contact list. Trace the edit state and list rendering paths; done means rejected edits do not appear as saved or create duplicate emails, while valid edits still display correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.