bigchaindb / bigchaindb/cryptoconditions

Provide ThresholdSha256Fulfillment.add_subfulfillments()?

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
proposal question
Dominant language
Python
Stars
73
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Being able to pass multiple fulfillments at once would be convenient. E.g., given:

```python
alice_ed25519 = Ed25519Fulfillment(public_key=alice.verifying_key)
bob_ed25519 = Ed25519Fulfillment(public_key=bob.verifying_key)
threshold_sha256 = ThresholdSha256Fulfillment(threshold=2)
```

currently:

```python
threshold_sha256.add_subfulfillment(alice_ed25519)
threshold_sha256.add_subfulfillment(bob_ed25519)
```

proposal:

```python
threshold_sha256.add_subfulfillments(alice_ed25519, bob_ed25519)
```

Contributor guide

Open the contributing guide

Research direction

Start by locating ThresholdSha256Fulfillment.add_subfulfillment() and any tests covering subfulfillment handling. Check how multiple arguments should be accepted and verify that add_subfulfillments(alice_ed25519, bob_ed25519) produces the same result as calling add_subfulfillment() twice.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cryptography
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.