bigchaindb / bigchaindb/cryptoconditions

SyntaxWarning due to comparison of literals using is

Open
#122 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
73
Forks
40
PR merge metrics
No merged PRs in 30d

Description

https://github.com/bigchaindb/cryptoconditions/blob/7ef4cc6f9248de32842e3ae365eb6f0d4adefb76/cryptoconditions/crypto.py#L33

This happens during setup.py installation in python 3.8

```
build/bdist.linux-x86_64/egg/cryptoconditions/crypto.py:33: SyntaxWarning: "is" with a literal. Did you mean "=="?
elif encoding is 'bytes':
```

Contributor guide

Open the contributing guide

Research direction

The warning points to cryptoconditions/crypto.py line 33 during setup.py installation. Inspect the encoding comparison there, then rerun installation under Python 3.8 and confirm that the SyntaxWarning no longer appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cryptography
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.