bfirsh / bfirsh/jsnes

Black Inset Border of Canvas Obstructing Display of Pixels

Open
#826 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
6.4k
Forks
857
PR merge metrics
No merged PRs in 30d

Description

This is happening in older v1 as well as the latest v2.1.0 versions of jsnes, regardless of whether manually I set the canvas image data from the frameBuffer or let the new `Browser` class handle it.

- The canvas is set to 256×240.
- Other than `display: block`, no CSS is applied that would add borders, render outline, or cause collisions with canvas rendering

Image

Image

The most noticeable instance is the Tecmo Super Bowl Team Control screen in which the team's names and selection SKP/MAN/COA/COM values are cut off.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the issue with a 256×240 canvas, then inspect the Browser class canvas-rendering path and the manual frameBuffer image-data path. Compare the rendered canvas bounds with the expected 256×240 display and verify that Tecmo Super Bowl text and selection values are no longer clipped.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.