bfast2 / bfast2/strucchangeRcpp

Why is the critval table static?

Open
#20 1 comment 0 reactions 0 assignees View on GitHub
help wanted question
Dominant language
R
Stars
6
Forks
5
PR merge metrics
No merged PRs in 30d

Description

There is a table of critical values at https://github.com/bfast2/strucchange/blob/master/R/critvals-monitoring.R which is used for ME and OLS-MOSUM processes. Why is it static, instead of being generated by a function? The table limits the p-values to 0.001 minimum, which in some cases is not conservative enough. It would be nice if arbitrary numbers could be used instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.