beyondcode / beyondcode/laravel-self-diagnosis

Remove schema prefix in ServersArePingable check

Open
#70 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
1.5k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

It would be very useful if there was an option per host for removing schema prefix (http://, https://), because when I want to use hostname from the config, like `config('app.url')`, it's very inconvenient to remove prefixes for each host.
Something like:
```php
\BeyondCode\SelfDiagnosis\Checks\ServersArePingable::class => [
'servers' => [
[
'host' => config('app.url'),
'port' => 80,
'timeout' => 1,
'remove_schema' => true,
],
]
]
```

@mpociot If you agree with the idea, I can implement and send PR

Contributor guide

Open the contributing guide

Research direction

Start by inspecting the ServersArePingable check and how its per-host configuration is read. Verify that a host configured with an HTTP or HTTPS prefix can be used when the new option is enabled, while existing host configurations continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
laravel, php
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.