beyond-all-reason / beyond-all-reason/demo-parser

Fix protocol version/header parsing

Open
#38 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Basically, the replay parser entirely ignores important fields like `headerSize`, doesn't check magic, network version and so on and so on.

This is a problem for engine https://github.com/beyond-all-reason/RecoilEngine/pull/2714 and very negatively contributes to the ecosystem blocking further changes.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the replay parser and inspect how it reads the demo header. Trace handling of headerSize and validation of the magic and network version, then use the engine issue and linked RecoilEngine pull request as context for expected protocol behavior. Done means these header fields are parsed and invalid values are checked rather than ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.