beyond-all-reason / beyond-all-reason/RecoilEngine

Feature Request: Bumpwater using engine uniform buffer sun so it tracks sun position changes.

Open
#680 4 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Currently, bumpwater uses #define'd SUNDIR, instead of engine uniform buffers. For dynamic sun, it would be ideal if bumpwater shader wouldnt have to be recompiled for each change.

Some other constants are:
fogColor
fogParams
GLSLDefineConstf1(definitions, "shadowDensity", sunLighting->groundShadowDensity);

Thank you very much!

Contributor guide

Open the contributing guide

Research direction

Search the bumpwater shader for the SUNDIR definition, then inspect how engine uniform buffers expose values such as fogColor and fogParams. Done means bumpwater reads sun direction through an engine uniform buffer so sun position changes no longer require shader recompilation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.