beyond-all-reason / beyond-all-reason/RecoilEngine

Set cmdTag as early as possible

Open
#3,356 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Here's a claim that for a new command, cmdTag only gets set "after all the callins" https://discord.com/channels/549281623154229250/643197947441315840/1548386054044786738

Check if this is the case and see how early the tag assignment can be pushed. It can't be all the way back (because there's a handful of unsynced callins right at the start) but the earlier the identity of a command can be established via the tag the better.

Contributor guide

Open the contributing guide

Research direction

Start by tracing where a new command is created and where cmdTag is assigned, then inspect the unsynced callins that occur at the start. Confirm how early the tag can be established without moving it before those callins. Done means cmdTag is assigned at the earliest safe point and existing command behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.