beyond-all-reason / beyond-all-reason/RecoilEngine

Check if `Script.UpdateCallIn` survives `/luaui reload`

Open
#3,337 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Apparently this registration:
https://github.com/beyond-all-reason/RecoilEngine/blob/977f612eb72da12939b3413884409bbf4001e348/rts/Lua/LuaHandle.cpp#L712

survives a `/luaui reload`. Check if this happens (I just got a report and didn't verify yet). Check other related registrations (like watch weapon etc) and the other handles (luarules etc).

Ideally the initial state after a reload would be predictable and the same as the initial load, i.e. the registrations should be dropped.

Contributor guide

Open the contributing guide

Research direction

Start at rts/Lua/LuaHandle.cpp around line 712 and reproduce whether Script.UpdateCallIn survives /luaui reload. Inspect related registrations such as watch weapon and the other handles, including luarules, then compare their state after reload with initial load. Done means registrations are consistently reset so reload starts from the same predictable state as initial loading.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, lua
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.