beyond-all-reason / beyond-all-reason/RecoilEngine
SetShockFrontFactors in LuaUnsyncedCtrl
- Dominant language
- C++
- Stars
- 679
- Forks
- 290
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
Why are we keeping this feature commented?
https://github.com/beyond-all-reason/RecoilEngine/blob/ae7580b6bed3e18d2bc82698c028ad9765b7a722/rts/Lua/LuaUnsyncedCtrl.cpp#L238
I know it says FIXME but there is a commit that is 9 years later and probably it solved the issue
https://github.com/beyond-all-reason/RecoilEngine/blob/ae7580b6bed3e18d2bc82698c028ad9765b7a722/rts/Lua/LuaUI.cpp#L670-L696
if it needs further Fixes or the function would be a good add to the engine i can work on it
Contributor guide
Research direction
Start with the commented SetShockFrontFactors area in rts/Lua/LuaUnsyncedCtrl.cpp around line 238, then compare it with the related implementation in rts/Lua/LuaUI.cpp around lines 670-696. Determine whether the FIXME is still valid and what verification is needed; done means the feature is either safely enabled with those fixes or its continued exclusion is documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, lua
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100