beyond-all-reason / beyond-all-reason/RecoilEngine

Get latest smmalloc

Open Beginner friendly
#3,147 3 comments 0 reactions 0 assignees View on GitHub
area: devops/gitops
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

We have an old version of the lib which leaks some `INLINE` macro that conflicts with other libraries and necessitates a dedicated wrapper header:
https://github.com/beyond-all-reason/RecoilEngine/blob/d6e9943238dc50dc7e4ebab8694ea66ac4c55835/rts/System/recoil-smmalloc.h#L5

Latest smmalloc has this fixed: https://github.com/SergeyMakeev/smmalloc/blob/master/SmMalloc/smmalloc.h#L120

See if we can update that dependency to latest.

Contributor guide

Open the contributing guide

Research direction

Start with rts/System/recoil-smmalloc.h and compare its wrapper need with the latest smmalloc.h at the linked upstream location. Locate the dependency definition in the repository, update it to the latest smmalloc version, and verify that the wrapper is no longer needed while the project still builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.