beyond-all-reason / beyond-all-reason/RecoilEngine

Replays cannot be loaded if too many individual players/spectators enter/leave during the match

Open
#2,850 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
679
Forks
290
Avg merge
3d 2h
Merged PRs (30d)
40

Description

Replays cannot be loaded if too many individual players/spectators enter/leave during the match. Even though there is always fewer than 254 players/spectators in the match, if the total number throughout the entire duration exceeds this limit (I think it is 254, otherwise something very close) then the resultant replay cannot be loaded by the engine.

Example Log Messages:
```
[t=00:00:29.878004][f=-000001] Too many Players (256) in the demo
[t=00:00:29.878010][f=-000001] Connection attempt from UnnamedPlayer (spec)
[t=00:00:29.878017][f=-000001] -> Version: 2025.06.19 [Windows 64-bit (native)]
[t=00:00:29.878948][f=-000001] [Game::ClientReadNet] added new player UnnamedPlayer (spec) with number 0 to team 0
[t=00:00:29.878964][f=-000001] -> Connection established (given id 256)
[t=00:00:29.878978][f=-000001] Got message 49 from 256 claiming to be from 0
[t=00:00:29.878984][f=-000001] Got message 49 from 256 claiming to be from 0
[t=00:00:29.878989][f=-000001] Got message 50 from 256 claiming to be from 0
```

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Reproduce the issue by having more than 254 distinct players or spectators enter and leave during a match, then load the resulting replay and compare the log with the reported messages. Done means the replay loads successfully even when the cumulative number of participants exceeds the limit.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.