beyond-all-reason / beyond-all-reason/RecoilEngine
Disabling movectrl removes from blockmap unconditionally?
- Dominant language
- C++
- Stars
- 679
- Forks
- 290
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 40
Description
This probably should happen under some condition, or possibly never, but idk.
https://github.com/beyond-all-reason/RecoilEngine/blob/2bcdeb3962a9cd556a76e829abe01e2eee921a0d/rts/Sim/MoveTypes/ScriptMoveType.cpp#L77
Leads to issues such as:
https://github.com/beyond-all-reason/Beyond-All-Reason/issues/757
With silly workarounds required:
https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5614
Contributor guide
Research direction
Start at rts/Sim/MoveTypes/ScriptMoveType.cpp:77 and trace what happens to the blockmap when movectrl is disabled. Review Beyond-All-Reason issue 757 and pull request 5614 for the reported effects and workaround. Done requires an agreed condition for removal, or confirmation that removal should not occur, along with a verified fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100